Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse IRI links #57

Merged
merged 75 commits into from
May 7, 2024
Merged

Parse IRI links #57

merged 75 commits into from
May 7, 2024

Conversation

farooqkz
Copy link
Collaborator

@farooqkz farooqkz commented Feb 11, 2024 •
edited by Simon-Laux
Loading

Implementing RFC3987

  • implement RFC3987 to parse internationalised links
  • update the link parsing to use the new logic (maybe as validation step, if it is too slow otherwise to run the whole correct parser if we don't even know yet wether we have a link at all)
  • add test cases

closes #16
closes #60
closes. #66

@Simon-Laux Simon-Laux mentioned this pull request Feb 11, 2024
Closed
3 tasks
@r10s r10s mentioned this pull request Feb 22, 2024
Closed
@Simon-Laux
Copy link
Member

let's squash merge this to keep a clean git history

@Simon-Laux Simon-Laux merged commit bbf5061 into master May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s left review comments

@Simon-Laux Simon-Laux Simon-Laux approved these changes

@adzialocha adzialocha Awaiting requested review from adzialocha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

links containing a ~ do not work links that have non spec chars in the location part are not clickable
3 participants
@farooqkz @Simon-Laux @r10s